Operator Spec PackageName #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmshort
reviewed
Dec 14, 2022
| @@ -9,4 +9,4 @@ metadata: | |||
| app.kubernetes.io/created-by: operator-controller | |||
| name: operator-sample | |||
| spec: | |||
| # TODO(user): Add fields here | |||
There was a problem hiding this comment.
Keep the TODO comment for future field adders?
tmshort
reviewed
Dec 14, 2022
| to remove/update | ||
| packageName: | ||
| maxLength: 48 | ||
| pattern: ^[a-z0-9]+(-[a-z0-9]+)*$ |
There was a problem hiding this comment.
Rules out camelCase, but I did see the discussion that this matches all current catalogs.
There was a problem hiding this comment.
True, but I think there's a good chance we'll be generating cluster resources with these names, and if that's the case we'd need to restrict camel case anyway
|
/approve |
tmshort
added
approved
awgreene
reviewed
Dec 15, 2022
| // Foo is an example field of Operator. Edit operator_types.go to remove/update | ||
| Foo string `json:"foo,omitempty"` | ||
| //+kubebuilder:validation:MaxLength:=48 | ||
| //+kubebuilder:validation:Pattern:=^[a-z0-9]+(-[a-z0-9]+)*$ |
There was a problem hiding this comment.
Should we support a packageName that starts with a number?
There was a problem hiding this comment.
hmm, 3scale operator jumps to mind.
There was a problem hiding this comment.
Yup, that's exactly why I allowed the numeral in there
|
Any other approval needed? @awgreene ? |
|
Merged. Thank you! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses Issue #69
Add package name to spec with validation, clear generated comments, run make, update sample CR
Tested by running: