Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 use FallbackToLogsOnError termination message policy #809

Merged

Conversation

joelanford
Copy link
Member

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@joelanford joelanford requested a review from a team as a code owner May 1, 2024 18:36
Copy link

netlify bot commented May 1, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 28ec719
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66328bcba4621d000814451c
😎 Deploy Preview https://deploy-preview-809--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.21%. Comparing base (79d64e8) to head (28ec719).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #809   +/-   ##
=======================================
  Coverage   67.21%   67.21%           
=======================================
  Files          23       23           
  Lines        1467     1467           
=======================================
  Hits          986      986           
  Misses        415      415           
  Partials       66       66           
Flag Coverage Δ
e2e 45.53% <ø> (ø)
unit 61.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m1kola m1kola added this pull request to the merge queue May 2, 2024
Merged via the queue into operator-framework:main with commit e32aa27 May 2, 2024
17 checks passed
@joelanford joelanford deleted the termination-message-policy branch June 20, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants