⚠ ClusterExtension: add installNamespace, remove watchNamespaces #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/hold I want to add a few more tests that are specific to the use of the new InstallNamespace field. |
openshift-ci
bot
added
the
do-not-merge/hold
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #810 +/- ##
==========================================
+ Coverage 64.64% 64.66% +0.01%
==========================================
Files 16 16
Lines 1321 1316 -5
==========================================
- Hits 854 851 -3
+ Misses 404 403 -1
+ Partials 63 62 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
joelanford
force-pushed
the
install-namespace
branch
from
d89641d
to
16012c4
Compare
openshift-merge-robot
added
the
needs-rebase
everettraven
reviewed
May 2, 2024
| {"hypen-separated", "hyphenated-name", ""}, | ||
| {"no install namespace", "", regexMismatchError}, | ||
| {"dot-separated", "dotted.name", regexMismatchError}, | ||
| {"includes version", "channel-has-version-1.0.1", regexMismatchError}, |
There was a problem hiding this comment.
We already check for dot separated, I don't think we need to explicitly check for "includes version" for install namespaces
Suggested change
| {"includes version", "channel-has-version-1.0.1", regexMismatchError}, |
There was a problem hiding this comment.
Yep good point, this was a copy/paste job from the channel name tests, and this one does not seem relevant here. I'll remove.
everettraven
previously approved these changes
May 2, 2024
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
joelanford
force-pushed
the
install-namespace
branch
from
16012c4
to
9befb90
Compare
openshift-merge-robot
removed
the
needs-rebase
everettraven
approved these changes
May 2, 2024
joelanford
removed
the
do-not-merge/hold
Merged
via the queue into
operator-framework:main
with commit May 2, 2024
0f85c25
16 of 17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
ClusterExtension:spec.installNamespaceas a required field. This will be used to configure the context of the client that templates and applies the bundle contents. This will also be necessary for the introduction of aspec.serviceAccountfield that operator-controller will use to perform all interactions with the apiserver for that ClusterExtension.spec.watchNamespacesand hardcode all registry+v1 based bundles to watch all namespaces (or fail if they don't support AllNamespaces mode)Reviewer Checklist