-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Helm poc unpack image #811
✨ Helm poc unpack image #811
Conversation
e0f2060
to
a26e609
Compare
@@ -6,3 +6,23 @@ images: | |||
- name: controller | |||
newName: quay.io/operator-framework/operator-controller | |||
newTag: devel | |||
replacements: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nice! I think in rukpak we had to manually edit the image in manager.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good! Thanks @dtfranz
Before merging, could you please test this and confirm if it works as expected locally as there are no tests in place for now.
f5c15bd
to
7d3049d
Compare
You need to do a |
You need to add an emoji to the start of the PR.
|
Also, seeing this error during
|
Builds and loads the unpacker binary into the operator-controller image so we don't need to use the rukpak image. Signed-off-by: dtfranz <dfranz@redhat.com>
7d3049d
to
23d20c1
Compare
Builds and loads the unpacker binary into the operator-controller image so we don't need to use the rukpak image. Signed-off-by: dtfranz <dfranz@redhat.com>
Builds and loads the unpacker binary into the operator-controller image so we don't need to use the rukpak image. Signed-off-by: dtfranz <dfranz@redhat.com>
Builds and loads the unpacker binary into the operator-controller image so we don't need to use the rukpak image. Signed-off-by: dtfranz <dfranz@redhat.com>
Builds and loads the unpacker binary into the operator-controller image so we don't need to use the rukpak image. Signed-off-by: dtfranz <dfranz@redhat.com>
Builds and loads the unpacker binary into the operator-controller image so we don't need to use the rukpak image. Signed-off-by: dtfranz <dfranz@redhat.com>
Builds and loads the unpacker binary into the operator-controller image so we don't need to use the rukpak image. Signed-off-by: dtfranz <dfranz@redhat.com>
Builds and loads the unpacker binary into the operator-controller image so we don't need to use the rukpak image. Signed-off-by: dtfranz <dfranz@redhat.com>
…s into the cluster (#846) * Helm POC rebase-a-thon * Unpack Image (#811) Builds and loads the unpacker binary into the operator-controller image so we don't need to use the rukpak image. Signed-off-by: dtfranz <dfranz@redhat.com> * ✨ OPRUN-3293 Fixes several unit tests - not cache ones (#831) * Fix, rm or skip BundleDeployment related tests Signed-off-by: Brett Tofel <btofel@redhat.com> * Address lint errors Signed-off-by: Brett Tofel <btofel@redhat.com> --------- Signed-off-by: Brett Tofel <btofel@redhat.com> * Fix e2e (#843) Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com> * Make goreleaser build unpack Signed-off-by: Brett Tofel <btofel@redhat.com> * Rm commented code Signed-off-by: Brett Tofel <btofel@redhat.com> * Rebase required changes Signed-off-by: Brett Tofel <btofel@redhat.com> * Cleanups (#854) Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com> * Expand comments in Dockerfile Signed-off-by: Brett Tofel <btofel@redhat.com> * Address Reviews Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com> * Back out packagerrors It's agreed that this makes debugging and reasoning about log messages and runtime errors much harder. Signed-off-by: Brett Tofel <btofel@redhat.com> * Helm POC e2e fixes (#870) Fixes the e2e tests in helm-poc branch and restores feature-gate switching. Signed-off-by: dtfranz <dfranz@redhat.com> * Fix defer location (#883) Fixes the defer location to make sure that all resources are cleaned up properly. Signed-off-by: dtfranz <dfranz@redhat.com> * Remove BundleDeployments gathering from e2e's gatherArtifacts (#886) When tests fail, gatherArtifacts is run to collect cluster state. This PR removes gathering of BundleDeployments since we don't use them anymore and it's generating additional misleading error messages. Signed-off-by: dtfranz <dfranz@redhat.com> * Address reviews (#887) Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com> * 🌱 Proposed way to unskip some tests (#874) * Proposed way to unskip some tests TestClusterExtensionChannelVersionExists mostly restored here Signed-off-by: Brett Tofel <btofel@redhat.com> * Refactors global variable names Signed-off-by: Brett Tofel <btofel@redhat.com> * Removes BundleDeployment related checking In just one test, for now. Signed-off-by: Brett Tofel <btofel@redhat.com> * fix unit test - TestClusterExtensionChannelVersionExists * Unskip all - failing tests (up|down)grade should err Unskips all in clusterextension_controller_test.go Signed-off-by: Brett Tofel <btofel@redhat.com> * Unskip all clusterextension_registryv1_validation_test.go Still failing tests (up|down)grade should err b/c we don't have an installedBundle to check against Signed-off-by: Brett Tofel <btofel@redhat.com> * debugging Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com> * Fixes and additions pending & unpack path Signed-off-by: Brett Tofel <btofel@redhat.com> * Fix linter, remove debug logs and extraneous file Signed-off-by: dtfranz <dfranz@redhat.com> * Fix e2e failure due to race condition Signed-off-by: dtfranz <dfranz@redhat.com> --------- Signed-off-by: Brett Tofel <btofel@redhat.com> Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com> Signed-off-by: dtfranz <dfranz@redhat.com> Co-authored-by: Varsha Prasad Narsing <varshaprasad96@gmail.com> Co-authored-by: dtfranz <dfranz@redhat.com> * Revert goreleaser to use buildx Signed-off-by: Brett Tofel <btofel@redhat.com> * Revert all of goreleaser to use buildx Signed-off-by: Brett Tofel <btofel@redhat.com> * Revert errorf->printf & rm some logging in tests Signed-off-by: Brett Tofel <btofel@redhat.com> --------- Signed-off-by: dtfranz <dfranz@redhat.com> Signed-off-by: Brett Tofel <btofel@redhat.com> Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com> Co-authored-by: Todd Short <tshort@redhat.com> Co-authored-by: Daniel Franz <dfranz@redhat.com> Co-authored-by: Varsha <varshaprasad96@gmail.com>
Builds and loads the unpacker binary into the operator-controller image so we don't need to use the rukpak image.