🐛 [Fix] Constant reconciles due to Catalog's poll interval #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
varshaprasad96
force-pushed
the
fix/constant-reconciles
branch
from
8c2f06c
to
337f73f
Compare
varshaprasad96
changed the title
joelanford
reviewed
May 2, 2024
varshaprasad96
force-pushed
the
fix/constant-reconciles
branch
from
337f73f
to
22962fd
Compare
everettraven
reviewed
May 3, 2024
Due to the polling feature in the Catalog, the `lastPolledInterval` in the Catalog's status gets updated. Because of this there is a reconcile is trigrred every time the catalog is polled, even though there is no change in the resolved image ref SHA. This causes unnecessary continuous reconciles in the CE. To overcome this, a Predicate is added to accept update events only when there is a change in Resolved reference. Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
varshaprasad96
force-pushed
the
fix/constant-reconciles
branch
from
22962fd
to
f1da0d9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #812 +/- ##
==========================================
+ Coverage 67.21% 71.04% +3.83%
==========================================
Files 23 16 -7
Lines 1467 1278 -189
==========================================
- Hits 986 908 -78
+ Misses 415 300 -115
- Partials 66 70 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to the polling feature in the Catalog, the
lastPolledIntervalin the Catalog's status gets updated. Because of this there is a reconcile triggered every time the catalog is polled, even though there is no change in the resolved image ref.This causes unnecessary continuous reconciles in the CE reconciler. To overcome this, a Predicate is added to accept update events only when there is a change in Resolved image reference in catalog's status.
Reviewer Checklist