Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Remove Scheme from ClusterExtensionReconciler #814

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented May 2, 2024

Description

It is an unused field.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

It is an unused field.

Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@m1kola m1kola added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 2, 2024
@m1kola m1kola requested a review from a team as a code owner May 2, 2024 08:08
Copy link

netlify bot commented May 2, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 42edda9
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/663349fdce1f870008f83dc3
😎 Deploy Preview https://deploy-preview-814--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.13%. Comparing base (e32aa27) to head (42edda9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #814      +/-   ##
==========================================
- Coverage   64.15%   64.13%   -0.03%     
==========================================
  Files          16       16              
  Lines        1303     1302       -1     
==========================================
- Hits          836      835       -1     
  Misses        404      404              
  Partials       63       63              
Flag Coverage Δ
e2e 41.78% <ø> (-0.05%) ⬇️
unit 56.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@everettraven everettraven added this pull request to the merge queue May 2, 2024
Merged via the queue into operator-framework:main with commit 5985cce May 2, 2024
17 checks passed
@m1kola m1kola deleted the remove_schema_from_ClusterExtensionReconciler branch May 3, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants