Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠ remove olm.bundle.mediatype property and clusterextension support for plain+v0 #822

Merged
merged 1 commit into from
May 3, 2024
Merged

⚠ remove olm.bundle.mediatype property and clusterextension support for plain+v0 #822

merged 1 commit into from
May 3, 2024

Conversation

joelanford
Copy link
Member

@joelanford joelanford commented May 2, 2024 •
edited
Loading

Fixes #822

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@joelanford joelanford requested a review from a team as a code owner May 2, 2024 21:29
@netlify Netlify
Copy link

netlify bot commented May 2, 2024 •
edited
Loading

✅ Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 7a045e1
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/6635125755f44f000846fef0
😎 Deploy Preview https://deploy-preview-822--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joelanford joelanford changed the title ⚠ remove olm.bundle.mediatype property and clusterextension support for… ⚠ remove olm.bundle.mediatype property and clusterextension support for plain+v0 May 2, 2024
everettraven
everettraven requested changes May 2, 2024
View reviewed changes
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably remove the plain-v0 entries under testdata/bundles as well

(Apologies if I missed the removal - on GH mobile so it's entirely possible I missed it being removed)

@joelanford joelanford mentioned this pull request May 2, 2024
Open
3 tasks
m1kola
m1kola reviewed May 3, 2024
View reviewed changes
Copy link
Member

@m1kola m1kola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do we do with this demo? It seem to rely on plain+v0 bundle types. I think this PR will break the demo.

internal/controllers/clusterextension_controller.go
}
// Assume all bundles are registry+v1 for now, since that's all we support.
// If the bundle is not a registry+v1 bundle, the conversion will fail.
bundleProvisioner := "core-rukpak-io-registry"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Maybe let's get rid of bundleProvisioner variable and of param in r.GenerateExpectedBundleDeployment?

Will help to reduce the noise in reconcile a little bit.

@codecov Codecov
Copy link

codecov bot commented May 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.86%. Comparing base (5985cce) to head (9748c03).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #822      +/-   ##
==========================================
+ Coverage   64.63%   70.86%   +6.22%     
==========================================
  Files          16       16              
  Lines        1315     1270      -45     
==========================================
+ Hits          850      900      +50     
+ Misses        403      300     -103     
- Partials       62       70       +8
Flag Coverage Δ
e2e 41.88% <100.00%> (-0.02%) ⬇️
unit 64.01% <100.00%> (+6.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 3, 2024
everettraven
everettraven previously approved these changes May 3, 2024
View reviewed changes
@everettraven
Copy link
Contributor

What do we do with this demo? It seem to rely on plain+v0 bundle types. I think this PR will break the demo.

I'd vote to either:

  • Remove it entirely since we have shifted direction quite significantly from when that was written
  • Update it accordingly

I personally am leaning towards removal since we are going to need to write new coast-to-coast documentation/tutorials for the new state of the world

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 3, 2024
@joelanford
Copy link
Member Author

I personally am leaning towards removal

I'll remove it. I was having similar thoughts as well.

@joelanford
remove olm.bundle.mediatype property and clusterextension support for…
7a045e1 
… plain+v0

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@joelanford joelanford added this pull request to the merge queue May 3, 2024
Merged via the queue into operator-framework:main with commit 4383624 May 3, 2024
16 checks passed
@joelanford joelanford mentioned this pull request May 14, 2024
Closed
@joelanford joelanford deleted the rm-plain-bundle branch June 20, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m1kola m1kola m1kola approved these changes

@everettraven everettraven everettraven left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joelanford @everettraven @m1kola @openshift-merge-robot