Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add test to verify registry+v1 webhooks limitation #830

Merged
merged 1 commit into from
May 13, 2024

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented May 3, 2024

Description

No bundles with webhooks are currently allowed and we must be clearly indicated in the conditions of ClusterExtension.

Closes #815

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 3, 2024
Copy link

netlify bot commented May 3, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit a91432f
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/663b9ea47e66d50008a728d0
😎 Deploy Preview https://deploy-preview-830--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@m1kola m1kola force-pushed the test_no_webhooks branch 2 times, most recently from 21d84b5 to 13d26c0 Compare May 8, 2024 15:19
No bundles with webhooks are currently allowed
and we must be clearly indicated in the conditions
of `ClusterExtension`

Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@m1kola m1kola marked this pull request as ready for review May 8, 2024 15:53
@m1kola m1kola requested a review from a team as a code owner May 8, 2024 15:53
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 8, 2024
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.02%. Comparing base (6d73b73) to head (a91432f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #830   +/-   ##
=======================================
  Coverage   71.02%   71.02%           
=======================================
  Files          17       17           
  Lines        1301     1301           
=======================================
  Hits          924      924           
  Misses        304      304           
  Partials       73       73           
Flag Coverage Δ
e2e 43.96% <ø> (+1.22%) ⬆️
unit 63.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@everettraven everettraven added this pull request to the merge queue May 13, 2024
Merged via the queue into operator-framework:main with commit 8e039f3 May 13, 2024
16 checks passed
@m1kola m1kola deleted the test_no_webhooks branch May 13, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests to confirm that registry+v1 bundles with webhooks are not allowed
2 participants