🌱 Update CONTAINER_TOOL evaluation in makefile to warn instead of error #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when unable to find docker or podman as this evaluation results in an error in environments where docker or podman is not installed even when using targets that do not require a container runtime Signed-off-by: everettraven <everettraven@gmail.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
joelanford
approved these changes
May 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #852 +/- ##
=======================================
Coverage 71.02% 71.02%
=======================================
Files 17 17
Lines 1301 1301
=======================================
Hits 924 924
Misses 304 304
Partials 73 73
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when unable to find docker or podman as this evaluation results in an error in environments where docker or podman is not installed even when using targets that do not require a container runtime
Description
CONTAINER_TOOLevaluation logic to warn instead of error out whendockerorpodmanare not detected in the path. This makes it so that in environments where neither is installed, running targets that don't require a container runtime can still be run. A caveat is that the targets needing a container runtime will still attempt to run and fail. I believe issuing a warning is a good middle ground to provide a clear reason why a target that requires a container runtime would fail, but am open to suggestions on better ways to approach this.Reviewer Checklist