Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add GitHub forms to the project #892

Merged
merged 1 commit into from
May 30, 2024

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented May 28, 2024

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 28, 2024
@m1kola m1kola marked this pull request as ready for review May 28, 2024 09:51
@m1kola m1kola requested a review from a team as a code owner May 28, 2024 09:51
Copy link

netlify bot commented May 28, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit dd0c980
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/6655a91933f0a700081fa168
😎 Deploy Preview https://deploy-preview-892--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 28, 2024
Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.18%. Comparing base (6060534) to head (dd0c980).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #892   +/-   ##
=======================================
  Coverage   83.18%   83.18%           
=======================================
  Files          15       15           
  Lines         874      874           
=======================================
  Hits          727      727           
  Misses        102      102           
  Partials       45       45           
Flag Coverage Δ
e2e 62.24% <ø> (ø)
unit 74.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tmshort
Copy link
Contributor

tmshort commented May 28, 2024

Interesting... what is the end-result of using the forms vs. the template? What does the resulting issue look like?

@m1kola
Copy link
Member Author

m1kola commented May 28, 2024

@tmshort forgot to mention In the PR - I have a repo with these configs. You can take a look at the live form here. In this repo I a already created a few issues, but feel free to submit more if you like.

Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2024
@tmshort tmshort added this pull request to the merge queue May 30, 2024
Merged via the queue into operator-framework:main with commit 5b64db2 May 30, 2024
16 checks passed
@m1kola m1kola deleted the gh-issue-forms branch June 3, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants