Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Update status update functions #908

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Jun 4, 2024

Remove references to rukpak k8s API where possible.

With the removal of Extension, the status update functions no longer need to be generic. Simplify the function signatures

This also makes the update functions consistent signature/behavior.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Remove references to rukpak k8s API where possible.

With the removal of Extension, the status update functions no longer
need to be generic. Simplify the function signatures

Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort tmshort requested a review from a team as a code owner June 4, 2024 17:55
Copy link

netlify bot commented Jun 4, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit c0a1193
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/665f551e436fe8000844eaf1
😎 Deploy Preview https://deploy-preview-908--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 56.66667% with 39 lines in your changes missing coverage. Please review.

Project coverage is 77.77%. Comparing base (841db34) to head (c0a1193).
Report is 2 commits behind head on main.

Files Patch % Lines
...nternal/controllers/clusterextension_controller.go 35.48% 20 Missing ⚠️
internal/controllers/common_controller.go 64.81% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #908      +/-   ##
==========================================
- Coverage   77.93%   77.77%   -0.16%     
==========================================
  Files          17       17              
  Lines        1142     1152      +10     
==========================================
+ Hits          890      896       +6     
- Misses        175      179       +4     
  Partials       77       77              
Flag Coverage Δ
e2e 59.80% <50.00%> (+<0.01%) ⬆️
unit 60.04% <42.22%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bentito
Copy link
Contributor

bentito commented Jun 5, 2024

/lgtm /approve

Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2024
@tmshort tmshort added this pull request to the merge queue Jun 5, 2024
Merged via the queue into operator-framework:main with commit 6028d95 Jun 5, 2024
15 of 17 checks passed
@tmshort tmshort deleted the update-status branch June 5, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants