-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Update status update functions #908
Conversation
Remove references to rukpak k8s API where possible. With the removal of Extension, the status update functions no longer need to be generic. Simplify the function signatures Signed-off-by: Todd Short <tshort@redhat.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #908 +/- ##
==========================================
- Coverage 77.93% 77.77% -0.16%
==========================================
Files 17 17
Lines 1142 1152 +10
==========================================
+ Hits 890 896 +6
- Misses 175 179 +4
Partials 77 77
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/lgtm /approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
6028d95
Remove references to rukpak k8s API where possible.
With the removal of Extension, the status update functions no longer need to be generic. Simplify the function signatures
This also makes the update functions consistent signature/behavior.
Description
Reviewer Checklist