⚠️ Update to go 1.22 #909
⚠️ Update to go 1.22 #909
Conversation
Fix issues with the extension-developer-e2e and operator-sdk Signed-off-by: Todd Short <tshort@redhat.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #909 +/- ##
==========================================
- Coverage 78.19% 73.49% -4.70%
==========================================
Files 17 18 +1
Lines 1142 1215 +73
==========================================
Hits 893 893
- Misses 173 246 +73
Partials 76 76
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -75,11 +75,14 @@ reg_pkg_name="${REG_PKG_NAME}" | |||
| ( | |||
| cd "${REG_DIR}" && \ | |||
| $operator_sdk init --domain="${DOMAIN}" && \ | |||
| sed -i -e 's/CONTROLLER_TOOLS_VERSION ?= v0.14.0/CONTROLLER_TOOLS_VERSION ?= v0.15.0/' Makefile && \ | |||
There was a problem hiding this comment.
Delete this line? Also while we're at it, could you add some comments about this sed command and the export OPERATOR_SDK line?
Something like these:
# controller-gen v0.13.0 (scaffolded by operator-sdk) panics when run with go 1.22, so pin to a more recent version. NOTE this is a rough edge that users will experience# The Makefile in the project scaffolded by operator-sdk uses an SDK binary in the path if it is present. Override to ensure we use the same version that we scaffolded with. NOTE: this is a rough edge that users will experience
There was a problem hiding this comment.
(sorry, didn't see/think of this when we were debugging it)
There was a problem hiding this comment.
I'll make sure it still works without this...
|
@tmshort the last commit in this PR was trying to do the same, without bumping go for now. We are bumping controller-gen for generating oc manifests here, but keeping controller-runtime and other related deps like helm-operator plugins the same. Its better to keep them tied together, so we can either bump it all in this or do an immediate follow up for the same? |
| @@ -23,11 +23,11 @@ $(BINGO): $(BINGO_DIR)/bingo.mod | |||
| @echo "(re)installing $(GOBIN)/bingo-v0.8.0" | |||
| @cd $(BINGO_DIR) && GOWORK=off $(GO) build -mod=mod -modfile=bingo.mod -o=$(GOBIN)/bingo-v0.8.0 "github.com/bwplotka/bingo" | |||
|
|
|||
| CONTROLLER_GEN := $(GOBIN)/controller-gen-v0.14.0 | |||
| CONTROLLER_GEN := $(GOBIN)/controller-gen-v0.15.0 | |||
There was a problem hiding this comment.
We are using an updated controller gen to generate and test manifests for operator controller, but keeping controller-runtime tied to a previous version. We can either bump controller-gen for o-c in a follow up with others, or do it all here. I would suggest the former, to keep this PR confined to fixing operator sdk with go 1.22 bump.
There was a problem hiding this comment.
Bumping controller-runtime starts a cascade effect of including k8s v0.30.0, so, yes, I'd prefer to do it later.
There was a problem hiding this comment.
Sounds good, then we don't need the changes in .bingo/. The only change required for controller-gen would be in the set up script that gets used for scaffolding the operator using SDK.
There was a problem hiding this comment.
The changes in bingo are necessary to install the the correct version of controller-gen, and to install a version of bingo that is compatible with go 1.22.
|
Bumping things like operator-controller, etc, creates an avalanche of other changes. To get things completed and done faster (i.e. reviews), it's easier to do smaller, incremental changes. We'll get there, it's just doing it in one big chunk is probably not a good idea. |
|
The executable for controller-gen has been updated consistently, so we're not running different versions of the same tool. |
Signed-off-by: Todd Short <tshort@redhat.com>
Fix issues with the extension-developer-e2e and operator-sdk
Description
Reviewer Checklist