✨ Move the e2e into the operator-controler-system ns #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To allow access to the docker-registry certificate, move the e2e resources into the same namespace as the operator-controller-system namespace. Signed-off-by: Todd Short <tshort@redhat.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #927 +/- ##
=======================================
Coverage 77.38% 77.38%
=======================================
Files 17 17
Lines 1163 1163
=======================================
Hits 900 900
Misses 183 183
Partials 80 80
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tmshort
added a commit
to tmshort/operator-controller
that referenced
this pull request
Jun 13, 2024
…framework#927)" This ends up overwriting the security policy of the operator-controller-system namespace, which really isn't something we want to do in a valid e2e test. Many of the e2e components need to run as root in order to do the things they need to do. This reverts commit aa48e70.
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 13, 2024
) This ends up overwriting the security policy of the operator-controller-system namespace, which really isn't something we want to do in a valid e2e test. Many of the e2e components need to run as root in order to do the things they need to do. This reverts commit aa48e70.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow access to the docker-registry certificate, move the e2e resources into the same namespace as the operator-controller-system namespace.
Description
Reviewer Checklist