Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Use apimachinery sets instead of maps #933

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

itroyano
Copy link
Contributor

Description

Fixes #881

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Igor Troyanovsky <itroyano@redhat.com>
@itroyano itroyano requested a review from a team as a code owner June 13, 2024 17:57
@itroyano itroyano marked this pull request as draft June 13, 2024 17:57
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 13, 2024
Copy link

netlify bot commented Jun 13, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 2e2e85e
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/666b33004250f100083d70da
😎 Deploy Preview https://deploy-preview-933--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.61%. Comparing base (8041cc4) to head (2e2e85e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #933      +/-   ##
==========================================
+ Coverage   79.15%   79.61%   +0.46%     
==========================================
  Files          15       15              
  Lines        1084     1084              
==========================================
+ Hits          858      863       +5     
+ Misses        157      154       -3     
+ Partials       69       67       -2     
Flag Coverage Δ
e2e 57.65% <100.00%> (+0.46%) ⬆️
unit 54.70% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@itroyano itroyano marked this pull request as ready for review June 13, 2024 18:29
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 13, 2024
Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2024
@tmshort tmshort added this pull request to the merge queue Jun 13, 2024
Merged via the queue into operator-framework:main with commit 5798a4a Jun 13, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use k8s.io/apimachinery/pkg/util/sets package
2 participants