-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix rbac generation in Makefile
#937
Conversation
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks for catching this, LGTM |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #937 +/- ##
==========================================
- Coverage 79.34% 79.16% -0.19%
==========================================
Files 16 16
Lines 1104 1104
==========================================
- Hits 876 874 -2
- Misses 158 159 +1
- Partials 70 71 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
should we also .gitignore config/rbac since it is generated? |
@grokspawn nothing should write into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with @m1kola. We aren't adding other generated files to gitignore, and should keep it the same for rbac.
/lgtm
/approve
Ah! I had leftover artifacts there after running the test for you this morning, and presumed that path was still used. If vestigial, ignore! |
126ddc4
Description
It looks like #888 we moved rbac manifests, but did not update controller-gen output path. This PR should fix this.
Reviewer Checklist