Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Update docs for catalogd TLS and other cleanup #940

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

trgeiger
Copy link
Contributor

@trgeiger trgeiger commented Jun 14, 2024

  • remove $ prompt from command examples
  • a couple small fixes in the README
  • update references to Catalogs to ClusterCatalogs

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

- remove $ prompt from command examples
- a couple small fixes in the README

Signed-off-by: Tayler Geiger <tayler@redhat.com>
@trgeiger trgeiger requested a review from a team as a code owner June 14, 2024 15:12
Copy link

netlify bot commented Jun 14, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 09a6148
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/666c5de83b29e8000805e6c2
😎 Deploy Preview https://deploy-preview-940--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.16%. Comparing base (edc91ad) to head (09a6148).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #940      +/-   ##
==========================================
- Coverage   79.34%   79.16%   -0.19%     
==========================================
  Files          16       16              
  Lines        1104     1104              
==========================================
- Hits          876      874       -2     
- Misses        158      159       +1     
- Partials       70       71       +1     
Flag Coverage Δ
e2e 57.60% <ø> (-0.55%) ⬇️
unit 53.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@everettraven everettraven added this pull request to the merge queue Jun 17, 2024
Merged via the queue into operator-framework:main with commit 74d2fd8 Jun 17, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants