🌱 Add test for fetching bundles

[m1kola]

Description

Cover what happens when we fail to fetch bundles from catalog.

This should solve flaky test coverage. It looks like in E2E we sometimes are hitting this condition and sometimes we don't which results in coverage fluctuation:

Reviewer Checklist

• API Go Documentation
• Tests: Unit Tests (and E2E Tests, if appropriate)
• Comprehensive Commit Messages
• Links to related GitHub Issue(s)

[netlify]

✅ Deploy Preview for olmv1 ready!

Name	Link
🔨 Latest commit	cd4084b
🔍 Latest deploy log	https://app.netlify.com/sites/olmv1/deploys/6673f1e00f968500084ec927
😎 Deploy Preview	https://deploy-preview-951--olmv1.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.14%. Comparing base (bfd4142) to head (cd4084b).
Report is 4 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #951   +/-   ##
=======================================
  Coverage   80.14%   80.14%           
=======================================
  Files          16       16           
  Lines        1103     1103           
=======================================
  Hits          884      884           
  Misses        152      152           
  Partials       67       67           

Flag	Coverage Δ
e2e	58.20% <ø> (ø)
unit	54.03% <ø> (+0.18%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[joelanford]

It looks like in E2E we sometimes are hitting this condition and sometimes we don't which results in coverage fluctuation

Adding more test coverage is good, but it seems pretty bad that other e2e tests are non-deterministic in this way. Did you dive into this enough to understand why the flakiness is happening?

[m1kola]

@joelanford Here is what I think happens:

1. We create a catalog.
2. We run a test.
3. We sometimes hit "error fetching bundles" and sometimes not. When we do hit it - it gets coverage.
4. E2Es wait for a certain condition and which gives the controller a chance to requeue the reconcile request. Eventually reconcile succeeds.

I think error happens because in tests we create catalogs and we do not wait for them to become ready: we create ClusterExtension immediately after creating a ClusterCatalog. So most likely ClusterExtension controller attempts to reconcile while catalog is still unpacking/not ready.

We can look into adding waits after creating ClusterCatalog, but IMO it is good that we do not have these artificial waits: we should be able to reconcile once catalog becomes ready.

[joelanford]

+100000 to not artificially wait. Expecting eventual consistency in our e2e's is the correct approach.

This makes sense. Thanks for the explanation.

[tmshort]

/lgtm