🐛 fix: remove unnecessary bundle cache volume #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When I removed the flag that controlled the bundle cache root directory in #941, I missed the fact that we also had a volumeMount for it, which is a child of our broader
/var/cachevolume emptyDir volume.This commit eliminates the unnecessary extra volume and instead just creates the
/var/cache/bundlesdirectory in the existing volume.This is important to eliminate the potential for issues when attempting to rename files across filesystem boundaries using
os.Rename(e.g. if we ever needed to do something like rename/var/cache/tmp/foobar.txtto/var/cache/bundles/foobar.txt)Reviewer Checklist