Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix: make installNamespace immutable #966

Merged

Conversation

joelanford
Copy link
Member

Description

Make spec.installNamespace immutable.

Fixes #961

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@joelanford joelanford requested a review from a team as a code owner June 22, 2024 00:25
Copy link

netlify bot commented Jun 22, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 9007c97
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/667619f1e05b230008ef65b4
😎 Deploy Preview https://deploy-preview-966--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@perdasilva perdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joelanford joelanford added this pull request to the merge queue Jun 24, 2024
Merged via the queue into operator-framework:main with commit 41f1593 Jun 24, 2024
15 checks passed
@joelanford joelanford deleted the immutable-install-namespace branch June 24, 2024 13:14
@skattoju skattoju mentioned this pull request Sep 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible bug: Do we properly handle mutations of spec.installNamespace?
2 participants