Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add -count=1 to local e2e tests to avoid caching #980

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Jun 25, 2024

Fixes issues with golang caching during e2e tests.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Todd Short <tshort@redhat.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 25, 2024
@tmshort tmshort marked this pull request as ready for review June 25, 2024 18:01
@tmshort tmshort requested a review from a team as a code owner June 25, 2024 18:01
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 25, 2024
Copy link

netlify bot commented Jun 25, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 210fedb
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/667b0604fdbb930008bca40d
😎 Deploy Preview https://deploy-preview-980--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tmshort
Copy link
Contributor Author

tmshort commented Jun 25, 2024

This affects only your local tests, CI tests are run in an environment where the cache is already clean.

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.40%. Comparing base (2eca31d) to head (210fedb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #980   +/-   ##
=======================================
  Coverage   79.40%   79.40%           
=======================================
  Files          17       17           
  Lines        1170     1170           
=======================================
  Hits          929      929           
  Misses        165      165           
  Partials       76       76           
Flag Coverage Δ
e2e 57.35% <ø> (ø)
unit 54.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grokspawn grokspawn changed the title 🌱 Add -count=1 to e2e tests to avoid caching 🌱 Add -count=1 to local e2e tests to avoid caching Jun 25, 2024
@grokspawn grokspawn added this pull request to the merge queue Jun 25, 2024
Merged via the queue into operator-framework:main with commit 500397e Jun 25, 2024
17 checks passed
@tmshort tmshort deleted the count1 branch June 26, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants