[resolution pt.5] olm variable source #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perdasilva
force-pushed
the
resolution_pt5_olm_variable_source
branch
2 times, most recently
from
ee1c20d
to
f228f35
Compare
perdasilva
changed the title
perdasilva
changed the title
perdasilva
force-pushed
the
resolution_pt5_olm_variable_source
branch
from
f228f35
to
86dcc2b
Compare
openshift-merge-robot
added
the
needs-rebase
perdasilva
force-pushed
the
resolution_pt5_olm_variable_source
branch
from
86dcc2b
to
21f0e5a
Compare
openshift-merge-robot
removed
the
needs-rebase
awgreene
approved these changes
Jan 26, 2023
Comment on lines
+119
to
+123
| It("should return an errors when they occur", func() { | ||
| olmVariableSource := olm.NewOLMVariableSource("prometheus", "packageA") | ||
| _, err := olmVariableSource.GetVariables(context.Background(), FailEntitySource{}) | ||
| Expect(err).To(HaveOccurred()) | ||
| }) |
There was a problem hiding this comment.
Does this sufficiently handle the case where an OLMVariableSource is provided that can't be fulfilled by the entity source?
There was a problem hiding this comment.
I suppose deppy would just return an error if resolution failed so we're probably good.
There was a problem hiding this comment.
Yeah, it should basically throw it's hand up in the air XD
Signed-off-by: perdasilva <perdasilva@redhat.com>
perdasilva
force-pushed
the
resolution_pt5_olm_variable_source
branch
from
21f0e5a
to
44f0bd3
Compare
Signed-off-by: perdasilva <perdasilva@redhat.com>
perdasilva
force-pushed
the
resolution_pt5_olm_variable_source
branch
from
44f0bd3
to
958d435
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
OLMVariableSourcewhich orchestrates variable creation by using the other variables sources (e.g.RequiredPackage,BundlesAndDeps, andGlobalConstraints)