-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Consolidate e2e CI jobs #993
Conversation
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
# By default make stops building on first non-zero exit code which | ||
# in case of E2E tests will mean that code coverage will only be | ||
# collected on successful runs. We want to collect coverage even | ||
# after failing tests. | ||
# With -k flag make will continue the build, but will return non-zero | ||
# exit code in case of any errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit is not longer relevant since at some point -k
was removed.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #993 +/- ##
=======================================
Coverage 77.19% 77.19%
=======================================
Files 17 17
Lines 1206 1206
=======================================
Hits 931 931
Misses 193 193
Partials 82 82
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Description
Consolidates 2 E2E jobs in a single workflow.
We will be adding another E2E (for operator-controller upgrade) and it would be good to have some consistency amongst these jobs (e.g. same triggers, etc).
Reviewer Checklist