Fix lint issues

Update golangci-lint to 1.57 Apply lint fixes
operator-framework · Apr 26, 2024 · 808c615 · 808c615
1 parent 7b4a134
commit 808c615
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -33,7 +33,7 @@ jobs:
         go-version-file: "go.mod"
     - uses: golangci/golangci-lint-action@v4
       with:
-        version: v1.51
+        version: v1.57
         args: --timeout 5m
 
   go-apidiff:

diff --git a/predicate/example_test.go b/predicate/example_test.go
@@ -40,7 +40,7 @@ func ExampleNewPause() {
 		os.Exit(1)
 	}
 
-	var r reconcile.Func = func(ctx context.Context, req reconcile.Request) (reconcile.Result, error) {
+	var r reconcile.Func = func(_ context.Context, _ reconcile.Request) (reconcile.Result, error) {
 		// Your reconcile logic would go here. No paused Pod events would trigger reconciliation.
 		return reconcile.Result{}, nil
 	}

diff --git a/prune/prune_test.go b/prune/prune_test.go
@@ -282,7 +282,7 @@ var _ = Describe("Prune", func() {
 					Expect(pruner).ShouldNot(BeNil())
 
 					// IsPrunableFunc that throws non Unprunable error
-					errorPrunableFunc := func(obj client.Object) error {
+					errorPrunableFunc := func(_ client.Object) error {
 						return fmt.Errorf("TEST")
 					}
 
@@ -309,7 +309,7 @@ var _ = Describe("Prune", func() {
 					Expect(jobs.Items).Should(HaveLen(3))
 
 					// strategy that will return an error
-					prunerStrategy := func(ctx context.Context, objs []client.Object) ([]client.Object, error) {
+					prunerStrategy := func(_ context.Context, _ []client.Object) ([]client.Object, error) {
 						return nil, fmt.Errorf("TESTERROR")
 					}
 

diff --git a/prune/strategies.go b/prune/strategies.go
@@ -26,7 +26,7 @@ import (
 // resources to prune based on a maximum count of resources allowed.
 // If the max count of resources is exceeded, the oldest resources are prioritized for pruning
 func NewPruneByCountStrategy(count int) StrategyFunc {
-	return func(ctx context.Context, objs []client.Object) ([]client.Object, error) {
+	return func(_ context.Context, objs []client.Object) ([]client.Object, error) {
 		if len(objs) <= count {
 			return nil, nil
 		}
@@ -47,7 +47,7 @@ func NewPruneByCountStrategy(count int) StrategyFunc {
 // NewPruneByDateStrategy returns a StrategyFunc that will return a list of
 // resources to prune where the resource CreationTimestamp is after the given time.Time.
 func NewPruneByDateStrategy(date time.Time) StrategyFunc {
-	return func(ctx context.Context, objs []client.Object) ([]client.Object, error) {
+	return func(_ context.Context, objs []client.Object) ([]client.Object, error) {
 		var objsToPrune []client.Object
 
 		for _, obj := range objs {