-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve prune feature implementation #101
Comments
everettraven
added a commit
to everettraven/operator-lib
that referenced
this issue
Apr 6, 2022
enable pruning of more than just Pod & Job resources related to operator-framework#101
everettraven
added a commit
to everettraven/operator-lib
that referenced
this issue
Apr 6, 2022
explain why k8s objects created with unstructured.Unstructured related to operator-framework#101
everettraven
added a commit
to everettraven/operator-lib
that referenced
this issue
Apr 6, 2022
refactored to make more readable and added some default IsPruneableFunc functions references operator-framework#101
everettraven
added a commit
to everettraven/operator-lib
that referenced
this issue
Apr 7, 2022
more testing coverage of the auto pruning functionality references operator-framework#101
everettraven
added a commit
to everettraven/operator-lib
that referenced
this issue
Apr 7, 2022
commit 82011ff9f7ea80eaab282388642bf3c1a23c2fdc Author: Bryce Palmer <bpalmer@redhat.com> Date: Thu Apr 7 11:19:36 2022 -0400 add more test cases more testing coverage of the auto pruning functionality references operator-framework#101 Signed-off-by: Bryce Palmer <bpalmer@redhat.com> commit 7a9d915 Author: Bryce Palmer <bpalmer@redhat.com> Date: Wed Apr 6 17:11:56 2022 -0400 refactor and add defaults refactored to make more readable and added some default IsPruneableFunc functions references operator-framework#101 commit 24409f4 Author: Bryce Palmer <bpalmer@redhat.com> Date: Wed Apr 6 13:29:31 2022 -0400 update a comment in tests explain why k8s objects created with unstructured.Unstructured related to operator-framework#101 commit 93334f6 Author: Bryce Palmer <bpalmer@redhat.com> Date: Wed Apr 6 13:24:52 2022 -0400 first draft of updated pruning API enable pruning of more than just Pod & Job resources related to operator-framework#101 Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Merged
everettraven
added a commit
to everettraven/operator-lib
that referenced
this issue
Apr 14, 2022
improve the existing prune package fixes operator-framework#101 Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
everettraven
added a commit
to everettraven/operator-lib
that referenced
this issue
Apr 14, 2022
improve the existing prune package fixes operator-framework#101 Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
everettraven
added a commit
that referenced
this issue
May 10, 2022
update the existing pruning library to implement the new library outlined in the following EP: https://github.com/operator-framework/enhancements/blob/master/enhancements/automatic-resource-pruning.md resolves #101
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Feature Request
Is your feature request related to a problem? Please describe.
It seems that the implementation of the prune feature could be improved. As part of the fix for PR #100 I noticed the following:
Config.Execute
. It does not sound right. Config may be passed to a factory creating a Pruner or a Processor structure but the Execuste method should be on the later structure: Pruner.Execute() or Processor.Execute() makes more sense.I haven't seen it really used. Is it thought more as a safety net (if anything is needed that was not foreseen get it through the context)? Can this be addressed through the closure approach?
The text was updated successfully, but these errors were encountered: