Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable max backoff interval in leader-for-life #102

Closed
lishunyao97 opened this issue Feb 7, 2022 · 4 comments · Fixed by #106
Closed

Configurable max backoff interval in leader-for-life #102

lishunyao97 opened this issue Feb 7, 2022 · 4 comments · Fixed by #106
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@lishunyao97
Copy link

Feature Request

Is your feature request related to a problem? Please describe.
Yes. I found that the hard-coded max backoff interval of 16s was too long for production environments. It introduced unnecessary leaderless time during deployment.

Describe the solution you'd like
Make maxBackoffInterval configurable, which can be passed in via Become's Option.
caueasantos added a commit to caueasantos/operator-lib that referenced this issue Apr 14, 2022
@caueasantos
Configurable max backoff interval in leader-for-life
42de32c 
* Renamed maxBackoffInterval constant
* Added MaxBackoffInterval field into Config
* Check if duration interval to become a leader is meaningful
* Added info log message with interval duration to give users bootstrap feedback

Fixes operator-framework#102
caueasantos added a commit to caueasantos/operator-lib that referenced this issue Apr 14, 2022
@caueasantos
* Renamed maxBackoffInterval constant
11c14be 
* Added MaxBackoffInterval field into Config
* Check if duration interval to become a leader is meaningful
* Removed info log message with interval duration

Fixes operator-framework#102
caueasantos added a commit to caueasantos/operator-lib that referenced this issue Apr 14, 2022
@caueasantos
Configurable max backoff interval in leader-for-life
4bd9c18 
* Renamed maxBackoffInterval constant
* Added MaxBackoffInterval field into Config
* Check if duration interval to become a leader is meaningful

Fixes operator-framework#102
@caueasantos caueasantos mentioned this issue Apr 15, 2022
Merged
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 9, 2022
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 8, 2022
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this as completed Jul 8, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jul 8, 2022

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmrodri jmrodri reopened this Aug 30, 2022
openshift-merge-robot pushed a commit that referenced this issue Aug 30, 2022
@caueasantos
Configurable max backoff interval in leader-for-life (#106)
58f9b32 
* Renamed maxBackoffInterval constant
* Added MaxBackoffInterval field into Config
* Check if duration interval to become a leader is meaningful

Fixes #102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #102: Make max backoff interval configurable caueasantos/operator-lib
3 participants
@jmrodri @openshift-bot @lishunyao97