Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/auto pruning #105

Merged
merged 12 commits into from
May 10, 2022
Merged

Feature/auto pruning #105

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
3e98659
update prune package
everettraven Apr 14, 2022
3f60543
address review comments (partial)
everettraven Apr 20, 2022
6768874
updates based on review comments
everettraven Apr 21, 2022
b850c0b
update tests for linting checks
everettraven Apr 21, 2022
c39650e
update tests
everettraven Apr 22, 2022
88fb3e0
update tests and nil verification
everettraven Apr 22, 2022
264c78d
Add common strategy functions
everettraven Apr 22, 2022
3bf051a
Add common strategies
everettraven Apr 22, 2022
230e74e
update sorting to save some CPU cycles
everettraven Apr 25, 2022
be7adfb
remove logger
everettraven May 3, 2022
7fb8237
export IsUnprunable
everettraven May 3, 2022
f881c0d
updates from review
everettraven May 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions prune/prune_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ var _ = Describe("Prune", func() {

Describe("Prune()", func() {
Context("Does not return an Error", func() {
It("Should Prune Pods with Default IsPrunableFunc", func() {
It("Should Prune Pods with Default IsPrunableFunc", func() { //nolint:dupl
// Create the test resources - in this case Pods
err := createTestPods(fakeClient)
Expect(err).Should(BeNil())
Expand All @@ -210,7 +210,7 @@ var _ = Describe("Prune", func() {
Expect(len(pods.Items)).Should(Equal(1))
})

It("Should Prune Jobs with Default IsPrunableFunc", func() {
It("Should Prune Jobs with Default IsPrunableFunc", func() { //nolint:dupl
everettraven marked this conversation as resolved.
Show resolved Hide resolved
// Create the test resources - in this case Jobs
err := createTestJobs(fakeClient)
Expect(err).Should(BeNil())
Expand Down