Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #102: Make max backoff interval configurable #106

Merged
merged 2 commits into from
Aug 30, 2022
Merged

Closes #102: Make max backoff interval configurable #106

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bd9c18
Configurable max backoff interval in leader-for-life
caueasantos Apr 14, 2022
c5dbfd9
Merge branch 'operator-framework:main' into main
caueasantos May 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 11 additions & 4 deletions leader/leader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,16 +42,17 @@ var readNamespace = utils.GetOperatorNamespace

var log = logf.Log.WithName("leader")

// maxBackoffInterval defines the maximum amount of time to wait between
// defaultMaxBackoffInterval defines the default maximum amount of time to wait between
// attempts to become the leader.
const maxBackoffInterval = time.Second * 16
const defaultMaxBackoffInterval = time.Second * 16

// Option is a function that can modify Become's Config
type Option func(*Config) error

// Config defines the configuration for Become
type Config struct {
Client crclient.Client
Client crclient.Client
MaxBackoffInterval time.Duration
}

func (c *Config) setDefaults() error {
Expand All @@ -67,6 +68,12 @@ func (c *Config) setDefaults() error {
}
c.Client = client
}

// Humans tend to understand a duration value as positive numbers. The constant
// defaultMaxBackoffInterval will overwrite the content to avoid an unintended behaviour.
if c.MaxBackoffInterval <= 0 {
c.MaxBackoffInterval = defaultMaxBackoffInterval
}
return nil
}

Expand Down Expand Up @@ -195,7 +202,7 @@ func Become(ctx context.Context, lockName string, opts ...Option) error {

select {
case <-time.After(wait.Jitter(backoff, .2)):
if backoff < maxBackoffInterval {
if backoff < config.MaxBackoffInterval {
backoff *= 2
}
continue
Expand Down