Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore): bump k8s to 1.24 #108

Merged

Conversation

everettraven
Copy link
Collaborator

Description of the change:

  • bump Kubernetes dependencies to k8s 1.24

  • remove workaround for DryRunClient in the prune library tests due to fix in controller-runtime

  • replace deprecated clock library with the new one in the conditions library tests

Motivation for the change:
Supporting k8s 1.24

Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented May 24, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign joelanford after the PR has been reviewed.
You can assign the PR to them by writing /assign @joelanford in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2380633864

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.703%

Totals Coverage Status
Change from base Build 2302145780: 0.0%
Covered Lines: 598
Relevant Lines: 706

💛 - Coveralls

Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 🥇

PS.: we need to upgrade kubebuilder otherwise we are unable to use this new version with SDK and bump the others libs

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2022
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 24, 2022
@camilamacedo86
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 25, 2022
Copy link
Member

@rashmigottipati rashmigottipati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@everettraven everettraven merged commit ab57f27 into operator-framework:main May 25, 2022
@everettraven everettraven deleted the chore/bump-k8s-1.24 branch May 25, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants