Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

predicate/nogeneration.go: add NoGenerationPredicate #11

Merged
merged 1 commit into from
Jul 24, 2020
Merged

predicate/nogeneration.go: add NoGenerationPredicate #11

merged 1 commit into from
Jul 24, 2020

Conversation

estroz
Copy link
Member

@estroz estroz commented Jul 24, 2020 •
edited

This PR adds NoGenerationPredicate, moved from operator-sdk's GenerationChangedPredicate, renamed, and updated to only allow objects that do not respect Generation to pass.

/cc @joelanford @jmrodri @hasbro17

@coveralls
Copy link

coveralls commented Jul 24, 2020 •
edited

Pull Request Test Coverage Report for Build 181635793

  • 18 of 18 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-4.8%) to 61.658%
Totals Coverage Status
Change from base Build 181341223: -4.8%
Covered Lines: 238
Relevant Lines: 386
💛 - Coveralls

joelanford
joelanford approved these changes Jul 24, 2020
View reviewed changes
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, otherwise
/lgtm

predicate/nogeneration.go Outdated Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2020
@joelanford
Copy link
Member

Also, add some ginkgo tests?

@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2020
@estroz estroz merged commit f6728cc into operator-framework:main Jul 24, 2020
@estroz estroz deleted the feature/no-generation-predicate branch July 24, 2020 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelanford joelanford joelanford approved these changes

@hasbro17 hasbro17 Awaiting requested review from hasbro17

@jmrodri jmrodri Awaiting requested review from jmrodri

Assignees

@joelanford joelanford

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@estroz @coveralls @joelanford @openshift-ci-robot