Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go version to v1.20 #121

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

rashmigottipati
Copy link
Member

No description provided.

Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
@rashmigottipati
Copy link
Member Author

cc @oceanc80 @everettraven

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8f73aea) 80.99% compared to head (189eb51) 80.99%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #121   +/-   ##
=======================================
  Coverage   80.99%   80.99%           
=======================================
  Files          17       17           
  Lines         484      484           
=======================================
  Hits          392      392           
  Misses         82       82           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
@rashmigottipati rashmigottipati changed the title Bump go version to v1.21 Bump go version to v1.20 Oct 13, 2023
Copy link
Collaborator

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2023
@varshaprasad96
Copy link
Member

@rashmigottipati looks like golangci-lint may be failing because of cache issues. I haven't dug more into this - but probably cache is enabled by default, which is why running setup-go multiple times is causing it to fail for every action. If a re-trigger does not fix it (just to ensure its not a flake), we can disable cache as a work around (golangci/golangci-lint-action#807). We should probably be opening an issue to investigate further on why this is happening, as disabling cache could make our CI runs slow.

@joelanford
Copy link
Member

This is a golangci-lint thing. It needs its version bumped to handle the new go version. You need at least version 1.51.0.

@oceanc80
Copy link
Contributor

/test lint

@openshift-ci
Copy link

openshift-ci bot commented Oct 20, 2023

@oceanc80: No presubmit jobs available for operator-framework/operator-lib@main

In response to this:

/test lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@everettraven
Copy link
Collaborator

/test lint

@oceanc80 I think that is a github action test, not one managed by prow. I'll close and re-open to try and kick tests and have them pick up the recent changes

@everettraven everettraven reopened this Oct 20, 2023
@oceanc80 oceanc80 merged commit 152ee1f into operator-framework:main Oct 20, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants