Bump golangci-lint to 1.51.0 #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Catherine Chan-Tse <cchantse@redhat.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #122 +/- ##
=======================================
Coverage 80.99% 80.99%
=======================================
Files 17 17
Lines 484 484
=======================================
Hits 392 392
Misses 82 82
Partials 10 10 ☔ View full report in Codecov by Sentry. |
| @@ -33,7 +33,7 @@ jobs: | |||
| go-version-file: "go.mod" | |||
| - uses: golangci/golangci-lint-action@v3 | |||
| with: | |||
| version: v1.49 | |||
| version: v1.51 | |||
There was a problem hiding this comment.
Not sure it really matters, but v1.55.0 was just released. If we want to not need to bump it for a little while longer it seems reasonable to just go to the latest version
everettraven
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Bump golangci-lint to 1.51.0
Motivation for the change:
golangci-lint 1.51.0+ is needed to be compatible with go 1.20