-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for InstrumentedEnqueueRequestForObject #15
Conversation
Pull Request Test Coverage Report for Build 188099145
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nits:
- Could we add the suffix
_test
which has special meaning for the Go compiler? So, it would bepackage handler_test
instead ofpackage handler
`
No, I wanted it in the same package as the code so I could also test the unexported methods. If we put it in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Added a test for the
InstrumentedEnqueueRequestForObject
to increase the code coverage.Before the test, handler was at 71.2%
After adding the test, coverage goes to 100%