Release leader for life lock in case pod is preempted. #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jagpreet Singh Tamber <jagpreetstamber@gmail.com>
jhmadhav
approved these changes
Mar 28, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
==========================================
+ Coverage 81.03% 87.44% +6.41%
==========================================
Files 17 17
Lines 485 494 +9
==========================================
+ Hits 393 432 +39
+ Misses 82 49 -33
- Partials 10 13 +3 ☔ View full report in Codecov by Sentry. |
everettraven
approved these changes
Mar 28, 2024
There was a problem hiding this comment.
Thanks @jagpreetstamber for the PR! I had one nit that I left as a comment, but it's more of a suggestion - feel free to make the change or leave as is.
Signed-off-by: Jagpreet Singh Tamber <jagpreetstamber@gmail.com>
Signed-off-by: Jagpreet Singh Tamber <jagpreetstamber@gmail.com>
|
New changes are detected. LGTM label has been removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Fix for issue #156
Motivation for the change:
Fix for issue #156