Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump k8s to 1.29 #163

Closed

Conversation

everettraven
Copy link
Collaborator

@everettraven everettraven commented Apr 18, 2024

Description of the change:

  • Bumps k8s libraries to 0.29.3
  • Bumps controller-runtime to 0.17.3
  • Bumps o-f/api to 0.23.0
  • Bumps Go to 1.22
  • Updates leader package test logic to fix a test failure related to the GVK and type meta not being set after performing a GET with a controller-runtime fake client

Motivation for the change:

  • Stay up to date with kubernetes bumps happening in Operator Framework projects

@everettraven everettraven requested a review from a team as a code owner April 18, 2024 17:53
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.79%. Comparing base (3bfabe0) to head (7e8b84d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #163      +/-   ##
==========================================
+ Coverage   88.75%   88.79%   +0.03%     
==========================================
  Files          17       18       +1     
  Lines         569      571       +2     
==========================================
+ Hits          505      507       +2     
  Misses         51       51              
  Partials       13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

leader/leader.go Outdated Show resolved Hide resolved
leader/leader.go Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
bump Go to 1.22
update tests to fix test failures

Signed-off-by: everettraven <everettraven@gmail.com>
Signed-off-by: everettraven <everettraven@gmail.com>
Signed-off-by: everettraven <everettraven@gmail.com>
@jberkhahn
Copy link

Looks like it's failing the linter? I definitely see a bunch of extraneous spaces that could be removed

@Neo2308
Copy link
Contributor

Neo2308 commented Apr 26, 2024

@everettraven missed your PR and had created a new one for these bumps: #167
Included your fixes over there, but didn't do the golang bump to 1.22 (shouldn't that be done when we bump to k8s 1.30?)

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 2, 2024
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants