-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release script #36
Add release script #36
Conversation
Pull Request Test Coverage Report for Build 305083719
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor addition to print out the next steps as reminders. The tool we had to build RPMs would do something like this:
[jesusr@camaro go-operator{master}]$ tito tag
Creating output directory: /tmp/tito
Tagging new version of go-operator: untagged -> 0.1.1-120201012224555.git.1.cab8ae7
Created tag: go-operator-0.1.1-120201012224555.git.1.cab8ae7
View: git show HEAD
Undo: tito tag -u
Push: git push --follow-tags origin
It's always a good reminder that running release.sh
isn't enough, and I don't have to go lookup another doc.
6e96832
to
98cc9f5
Compare
Add release script and corresponding steps.
98cc9f5
to
482f2da
Compare
echo "git push upstream <release-branch>" | ||
echo "git push upstream $VER" | ||
echo "" | ||
echo "Also update the release notes in github for this tag." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not for this PR, but in the future it would be interesting to use goreleaser to automatically produce the GitHub release when a tag is pushed.
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmrodri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of the change:
Add release script and corresponding steps.
Motivation for the change: