Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release script #36

Conversation

varshaprasad96
Copy link
Member

Description of the change:
Add release script and corresponding steps.

Motivation for the change:

@coveralls
Copy link

coveralls commented Oct 13, 2020

Pull Request Test Coverage Report for Build 305083719

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.921%

Totals Coverage Status
Change from base Build 298553754: 0.0%
Covered Lines: 268
Relevant Lines: 353

💛 - Coveralls

Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor addition to print out the next steps as reminders. The tool we had to build RPMs would do something like this:

[jesusr@camaro go-operator{master}]$ tito tag
Creating output directory: /tmp/tito
Tagging new version of go-operator: untagged -> 0.1.1-120201012224555.git.1.cab8ae7
Created tag: go-operator-0.1.1-120201012224555.git.1.cab8ae7
   View: git show HEAD
   Undo: tito tag -u
   Push: git push --follow-tags origin

It's always a good reminder that running release.sh isn't enough, and I don't have to go lookup another doc.

release.sh Outdated Show resolved Hide resolved
release.sh Show resolved Hide resolved
Add release script and corresponding steps.
echo "git push upstream <release-branch>"
echo "git push upstream $VER"
echo ""
echo "Also update the release notes in github for this tag."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for this PR, but in the future it would be interesting to use goreleaser to automatically produce the GitHub release when a tag is pushed.

https://goreleaser.com/cookbooks/release-a-library/

@jmrodri
Copy link
Member

jmrodri commented Oct 14, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2020
@jmrodri
Copy link
Member

jmrodri commented Oct 14, 2020

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmrodri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2020
@openshift-merge-robot openshift-merge-robot merged commit 659d5a8 into operator-framework:main Oct 14, 2020
@varshaprasad96 varshaprasad96 deleted the add/release-script branch October 14, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants