Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping to Go 1.15 #38

Merged
merged 2 commits into from
Nov 16, 2020

Conversation

jmrodri
Copy link
Member

@jmrodri jmrodri commented Nov 16, 2020

Description of the change:
Bumping go from 1.13 to 1.15 in go.mod.

Motivation for the change:
Moving to Go 1.15 like we did for operator-sdk: https://github.com/operator-framework/operator-sdk/blob/master/go.mod#L3

@coveralls
Copy link

coveralls commented Nov 16, 2020

Pull Request Test Coverage Report for Build 366310051

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.921%

Totals Coverage Status
Change from base Build 306912882: 0.0%
Covered Lines: 268
Relevant Lines: 353

💛 - Coveralls

Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After update the CI:

go-version: ^1.13

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2020
@joelanford
Copy link
Member

/approve

But can we go ahead and bump the line that @camilamacedo86 mentioned in this PR? Feel free to remove the hold once the github action workflow is updated to 1.15.
/hold

In addition to that one, we also need to update the base image for the openshift/release job.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 16, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelanford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2020
@jmrodri
Copy link
Member Author

jmrodri commented Nov 16, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 16, 2020
@joelanford
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2020
@openshift-merge-robot openshift-merge-robot merged commit 745465e into operator-framework:main Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants