-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add library to interact with operator conditions #43
Add library to interact with operator conditions #43
Conversation
This PR removes the previous operator_conditions package and introduces a `Conditions` interface, using which one can: 1. Get an existing condition from the operator conditions CR in cluster. 2. Create/Update a condition in the operator condition CR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
This looks a lot better. Great work!
61de90d
to
c27bcdc
Compare
c27bcdc
to
13728c2
Compare
Pull Request Test Coverage Report for Build 399902217
💛 - Coveralls |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmrodri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -0,0 +1,96 @@ | |||
#!/usr/bin/env bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: this file should be ignored by adding **/testbin/*
to the .gitignore
.
Description of the change:
This PR removes the previous operator_conditions package and
introduces a
Conditions
interface, using which one can:Motivation for the change:
EP: Operator-Conditions lib