Add library to interact with operator conditions #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes the previous operator_conditions package and introduces a `Conditions` interface, using which one can: 1. Get an existing condition from the operator conditions CR in cluster. 2. Create/Update a condition in the operator condition CR.
jmrodri
approved these changes
Dec 4, 2020
openshift-ci-robot
added
lgtm
varshaprasad96
force-pushed
the
operator-conditions/lib
branch
2 times, most recently
from
61de90d
to
c27bcdc
Compare
varshaprasad96
force-pushed
the
operator-conditions/lib
branch
from
c27bcdc
to
13728c2
Compare
Pull Request Test Coverage Report for Build 399902217
💛 - Coveralls |
jmrodri
changed the title
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmrodri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
estroz
reviewed
Dec 4, 2020
| @@ -0,0 +1,96 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
Nit: this file should be ignored by adding **/testbin/* to the .gitignore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
This PR removes the previous operator_conditions package and
introduces a
Conditionsinterface, using which one can:Motivation for the change:
EP: Operator-Conditions lib