Ignore time in ManagedFields when processing events from dependent resources #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 796717230
💛 - Coveralls |
fabianvf
force-pushed
the
dependent-managed-fields
branch
2 times, most recently
from
e409807
to
95bad8f
Compare
…sources Signed-off-by: Fabian von Feilitzsch <fabian@fabianism.us>
fabianvf
force-pushed
the
dependent-managed-fields
branch
from
95bad8f
to
1030055
Compare
|
/approved |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmrodri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Ignores time in ManagedFields when determining whether events should be skipped. This gets us back the behavior we had before managedFields were added, as when the kubelet updates the resourceVersion it also updates the time in its managedFields entry.
Motivation for the change:
We've had users reporting infinite reconciliation and this is likely the culprit.
Fixes operator-framework/operator-sdk#3950
Fixes operator-framework/operator-sdk#4258