Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ErrNoOperatorCondition error #66

Merged
merged 1 commit into from
Jul 7, 2021
Merged

Remove ErrNoOperatorCondition error #66

merged 1 commit into from
Jul 7, 2021

Conversation

awgreene
Copy link
Member

@awgreene awgreene commented Jul 7, 2021

No description provided.

@awgreene awgreene mentioned this pull request Jul 7, 2021
Merged
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1008782968

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.187%
Totals Coverage Status
Change from base Build 1008755024: 0.0%
Covered Lines: 331
Relevant Lines: 418
💛 - Coveralls

@varshaprasad96 varshaprasad96 mentioned this pull request Jul 7, 2021
Closed
@joelanford
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2021
varshaprasad96
varshaprasad96 approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link

openshift-ci bot commented Jul 7, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: varshaprasad96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2021
@varshaprasad96
Copy link
Member

/override go-apidiff

@openshift-ci
Copy link

openshift-ci bot commented Jul 7, 2021

@varshaprasad96: /override requires a failed status context to operate on.
The following unknown contexts were given:

  • go-apidiff

Only the following contexts were expected:

  • ci/prow/test-all
  • tide

In response to this:

/override go-apidiff

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@varshaprasad96
Copy link
Member

/override tide

@openshift-ci
Copy link

openshift-ci bot commented Jul 7, 2021

@varshaprasad96: Overrode contexts on behalf of varshaprasad96: tide

In response to this:

/override tide

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@varshaprasad96 varshaprasad96 merged commit ec654a6 into operator-framework:main Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varshaprasad96 varshaprasad96 varshaprasad96 approved these changes

@camilamacedo86 camilamacedo86 Awaiting requested review from camilamacedo86

@theishshah theishshah Awaiting requested review from theishshah

Assignees

@joelanford joelanford

@varshaprasad96 varshaprasad96

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@awgreene @coveralls @joelanford @varshaprasad96