change prune strategy to separate resource removal from the strategy … #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Pull Request Test Coverage Report for Build 1394911945
💛 - Coveralls |
jmrodri
approved these changes
Oct 29, 2021
|
/lgtm |
ryantking
suggested changes
Oct 29, 2021
| return err | ||
| } | ||
| default: | ||
| return fmt.Errorf("unsupported resource kind") | ||
| } |
There was a problem hiding this comment.
Can move each error check to a single one after the switch
ryantking
approved these changes
Oct 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
this change separates out the removal of resources logic from the various prune strategy implementations so that someone writing a custom strategy doesn't have to worry about implementing or calling resource removal logic themselves.
Motivation for the change:
this should make it easier for custom strategy implementations to be developed since they would not have to remember to call resource removal logic directly.