-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove locks for Pods in "Shutdown" status #77
Conversation
Kubernetes introduced "Graceful Node Shutdown" as an Alpha feature in 1.20. Pods that are evicted by this mechanism have their status.reason attribute set to "Shutdown". This commit extends the garbage collection so that locks for Pods in the "Shutdown" state are also released.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @scheying. Thanks for your PR. I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
@fabianvf @joelanford would you mind having a look, please? The change looks pretty straightforward (and very small anyway) and the issue also exists for us… 😊 |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Kubernetes introduced "Graceful Node Shutdown" as an Alpha feature in 1.20. Pods that are evicted by this mechanism have their status.reason attribute set to "Shutdown". This commit extends the garbage collection so that locks for Pods in the "Shutdown" state are also released.
Deadlocks caused by Pods in "shutdown" state still holding leader locks were observed on a live GKE Cluster with preemtible nodes.
This might also fix #73.