controller/registry/resolver: detect incoherent state

Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
operator-framework · Oct 10, 2023 · 6f751b7 · 6f751b7
1 parent 5a680ad
commit 6f751b7
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 5 deletions.
diff --git a/pkg/controller/registry/resolver/source_csvs.go b/pkg/controller/registry/resolver/source_csvs.go
@@ -8,13 +8,15 @@ import (
 
 	"github.com/blang/semver/v4"
 	"github.com/operator-framework/api/pkg/operators/v1alpha1"
+	operatorv1clientset "github.com/operator-framework/operator-lifecycle-manager/pkg/api/client/clientset/versioned"
 	v1listers "github.com/operator-framework/operator-lifecycle-manager/pkg/api/client/listers/operators/v1"
 	v1alpha1listers "github.com/operator-framework/operator-lifecycle-manager/pkg/api/client/listers/operators/v1alpha1"
 	"github.com/operator-framework/operator-lifecycle-manager/pkg/controller/registry/resolver/cache"
 	"github.com/operator-framework/operator-lifecycle-manager/pkg/controller/registry/resolver/projection"
 	"github.com/operator-framework/operator-registry/pkg/api"
 	opregistry "github.com/operator-framework/operator-registry/pkg/registry"
 	"github.com/sirupsen/logrus"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/labels"
 )
 
@@ -23,6 +25,7 @@ type csvSourceProvider struct {
 	subLister v1alpha1listers.SubscriptionLister
 	ogLister  v1listers.OperatorGroupLister
 	logger    logrus.StdLogger
+	client    operatorv1clientset.Interface
 }
 
 func (csp *csvSourceProvider) Sources(namespaces ...string) map[cache.SourceKey]cache.Source {
@@ -34,6 +37,7 @@ func (csp *csvSourceProvider) Sources(namespaces ...string) map[cache.SourceKey]
 			subLister: csp.subLister.Subscriptions(namespace),
 			ogLister:  csp.ogLister.OperatorGroups(namespace),
 			logger:    csp.logger,
+			client:    csp.client,
 		}
 		break // first ns is assumed to be the target ns, todo: make explicit
 	}
@@ -46,6 +50,8 @@ type csvSource struct {
 	subLister v1alpha1listers.SubscriptionNamespaceLister
 	ogLister  v1listers.OperatorGroupNamespaceLister
 	logger    logrus.StdLogger
+
+	client operatorv1clientset.Interface
 }
 
 func (s *csvSource) Snapshot(ctx context.Context) (*cache.Snapshot, error) {
@@ -85,6 +91,20 @@ func (s *csvSource) Snapshot(ctx context.Context) (*cache.Snapshot, error) {
 			continue
 		}
 
+		if cachedSubscription, ok := csvSubscriptions[csv]; !ok || cachedSubscription == nil {
+			// we might be in an incoherent state, so let's check with live clients to make sure
+			realSubscriptions, err := s.client.OperatorsV1alpha1().Subscriptions(csv.Namespace).List(ctx, metav1.ListOptions{})
+			if err != nil {
+				return nil, fmt.Errorf("failed to list subscriptions: %w", err)
+			}
+			for _, realSubscription := range realSubscriptions.Items {
+				if realSubscription.Status.InstalledCSV == csv.Name {
+					// oops, live cluster state is coherent
+					return nil, fmt.Errorf("lister caches incoherent for CSV %s/%s - found owning Subscription %s/%s", csv.Namespace, csv.Name, realSubscription.Namespace, realSubscription.Name)
+				}
+			}
+		}
+
 		if failForwardEnabled {
 			replacementChainEndsInFailure, err := isReplacementChainThatEndsInFailure(csv, ReplacementMapping(csvs))
 			if err != nil {

diff --git a/pkg/controller/registry/resolver/step_resolver.go b/pkg/controller/registry/resolver/step_resolver.go
@@ -5,18 +5,17 @@ import (
 	"context"
 	"fmt"
 
-	"github.com/sirupsen/logrus"
-	corev1 "k8s.io/api/core/v1"
-	"k8s.io/apimachinery/pkg/api/errors"
-	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
-
 	"github.com/operator-framework/api/pkg/operators/v1alpha1"
 	"github.com/operator-framework/operator-lifecycle-manager/pkg/api/client/clientset/versioned"
 	v1alpha1listers "github.com/operator-framework/operator-lifecycle-manager/pkg/api/client/listers/operators/v1alpha1"
 	controllerbundle "github.com/operator-framework/operator-lifecycle-manager/pkg/controller/bundle"
 	"github.com/operator-framework/operator-lifecycle-manager/pkg/controller/registry/resolver/cache"
 	"github.com/operator-framework/operator-lifecycle-manager/pkg/controller/registry/resolver/projection"
 	"github.com/operator-framework/operator-lifecycle-manager/pkg/lib/operatorlister"
+	"github.com/sirupsen/logrus"
+	corev1 "k8s.io/api/core/v1"
+	"k8s.io/apimachinery/pkg/api/errors"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 )
 
 const (
@@ -63,6 +62,7 @@ func NewOperatorStepResolver(lister operatorlister.OperatorLister, client versio
 				subLister: lister.OperatorsV1alpha1().SubscriptionLister(),
 				ogLister:  lister.OperatorsV1().OperatorGroupLister(),
 				logger:    log,
+				client:    client,
 			},
 		},
 	}