[CatalogSource] Set Global Catalog NS with EnvVar #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
jpeeler
reviewed
Aug 28, 2019
cmd/catalog/main.go
Outdated
| @@ -79,6 +80,11 @@ func main() { | |||
| // Parse the command-line flags. | |||
| flag.Parse() | |||
|
|
|||
| // If the catalogNamespaceEnvVarName environment variable is set update the value of catalogNamespace. | |||
| if catalogNamespaceEnvVarValue := os.Getenv(catalogNamespaceEnvVarName); catalogNamespaceEnvVarValue != "" { | |||
There was a problem hiding this comment.
Might be nice to add some logging that the namespace is being set via env var, just to make it super clear.
There was a problem hiding this comment.
And perhaps a commented out example in one of the helm deploy templates too (maybe).
awgreene
force-pushed
the
configure-global-catalog-ns
branch
2 times, most recently
from
89ab900 to
16e25e2
Compare
|
/lgtm |
openshift-ci-robot
added
lgtm
ecordell
reviewed
Aug 28, 2019
|
/hold based on Evan's #1014 (comment) |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
awgreene
force-pushed
the
configure-global-catalog-ns
branch
from
16e25e2 to
af4e8c3
Compare
This commit introduces a change that makes it possible to configure the Global Catalog Namespace by adding the CATALOG_NAMESPACE environment variable to the catalog-operator deployment.
awgreene
force-pushed
the
configure-global-catalog-ns
branch
from
af4e8c3 to
c0b2c3c
Compare
|
/hold cancel |
openshift-ci-robot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awgreene, jpeeler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a change that makes it possible to configure the
Global Catalog Namespace by adding the CATALOG_NAMESPACE environment
variable to the catalog-operator deployment.