Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1744245: Subscription should not point to deleted ip #1023

Merged

Conversation

tkashem
Copy link
Collaborator

@tkashem tkashem commented Sep 3, 2019

Delete and recreate of a subscription object without any delay causes
operator install to fail.

How to reproduce:

  1. Create a CatalogSource object, wait for it to become healthy.
  2. Create a Subscription that refers to the CatalogSource above.
  3. Wait for the operator to install successfully.
  4. Update the CatalogSource
  5. Wait for the updated CatalogSource to become healthy.
  6. Delete the Subscription object ( created above ).
  7. Recreate the Subscription object ( no time delay between delete
    and create ). Delete and Create can be done one after another, there
    is no need to make them concurrent.

Solution:

  • The InstallPlan object(s) are listed using a lister which may
    return a deleted InstallPlan object. Use a non-cached client
    to query list of InstallPlan object(s)

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1744245

Delete and recreate of a subscription object without any delay causes
operator install to fail.

How to reproduce:

1. Create a CatalogSource object, wait for it to become healthy.
2. Create a Subscription that refers to the CatalogSource above.
3. Wait for the operator to install successfully.
4. Update the CatalogSource
5. Wait for the updated CatalogSource to become healthy.
6. Delete the Subscription object ( created above ).
7. Recreate the Subscription object ( no time delay between delete
and create ). Delete and Create can be done one after another, there
is no need to make them concurrent.

Solution:
 - The InstallPlan object(s) are listed using a lister which may
   return a deleted InstallPlan object. Use a non-cached client
   to query list of InstallPlan object(s)

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1744245
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 3, 2019
@tkashem
Copy link
Collaborator Author

tkashem commented Sep 3, 2019

/refresh bugzilla

@tkashem
Copy link
Collaborator Author

tkashem commented Sep 3, 2019

/bugzilla refresh

@openshift-ci-robot
Copy link
Collaborator

@tkashem: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tkashem tkashem changed the title Bugzilla 1744245: Subscription should not point to deleted ip Bug 1744245: Subscription should not point to deleted ip Sep 3, 2019
@openshift-ci-robot
Copy link
Collaborator

@tkashem: This pull request references Bugzilla bug 1744245, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1744245: Subscription should not point to deleted ip

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 3, 2019
@tkashem
Copy link
Collaborator Author

tkashem commented Sep 3, 2019

/bugzilla refresh

@openshift-ci-robot
Copy link
Collaborator

@tkashem: This pull request references Bugzilla bug 1744245, which is valid.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tkashem
Copy link
Collaborator Author

tkashem commented Sep 3, 2019

/retest

Copy link
Member

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2019
@openshift-merge-robot openshift-merge-robot merged commit db97a17 into operator-framework:master Sep 4, 2019
@openshift-ci-robot
Copy link
Collaborator

@tkashem: All pull requests linked via external trackers have merged. Bugzilla bug 1744245 has been moved to the MODIFIED state.

In response to this:

Bug 1744245: Subscription should not point to deleted ip

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants