-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1744245: Subscription should not point to deleted ip #1023
Bug 1744245: Subscription should not point to deleted ip #1023
Conversation
Delete and recreate of a subscription object without any delay causes operator install to fail. How to reproduce: 1. Create a CatalogSource object, wait for it to become healthy. 2. Create a Subscription that refers to the CatalogSource above. 3. Wait for the operator to install successfully. 4. Update the CatalogSource 5. Wait for the updated CatalogSource to become healthy. 6. Delete the Subscription object ( created above ). 7. Recreate the Subscription object ( no time delay between delete and create ). Delete and Create can be done one after another, there is no need to make them concurrent. Solution: - The InstallPlan object(s) are listed using a lister which may return a deleted InstallPlan object. Use a non-cached client to query list of InstallPlan object(s) Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1744245
/refresh bugzilla |
/bugzilla refresh |
@tkashem: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@tkashem: This pull request references Bugzilla bug 1744245, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@tkashem: This pull request references Bugzilla bug 1744245, which is valid. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell, tkashem The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@tkashem: All pull requests linked via external trackers have merged. Bugzilla bug 1744245 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Delete and recreate of a subscription object without any delay causes
operator install to fail.
How to reproduce:
and create ). Delete and Create can be done one after another, there
is no need to make them concurrent.
Solution:
return a deleted InstallPlan object. Use a non-cached client
to query list of InstallPlan object(s)
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1744245