feat(metrics) record CSV failures #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
awgreene
commented
Oct 1, 2019
awgreene
force-pushed
the
csv-health-metrics
branch
from
f2c78f9 to
3827ec9
Compare
awgreene
commented
Oct 2, 2019
awgreene
force-pushed
the
csv-health-metrics
branch
from
3827ec9 to
8c851f8
Compare
This commit introduces a change so OLM will expose metrics about CSV sync events.
awgreene
force-pushed
the
csv-health-metrics
branch
from
8c851f8 to
a2606a1
Compare
|
/lgtm Giving a pass on missing docs since we're restructuring those at the moment 😄 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awgreene, ecordell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a change so OLM will exposed metrics about a CSV
whenever either of the following conditions are met:
The metrics are recorded with name, version, and reason labels.