-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: RelatedImages #1069
Proposal: RelatedImages #1069
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ecordell: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Verbal approval from @shawn-hurley and I want to reference this doc, so merging now and if we need to change something we can make a new PR. |
Not sure how to comment on the proposal, so adding my two cents here... Would it be better to put this information into a separate file in the metadata bundle? I think this would be a simpler solution than modifying the csv file every time an image used within it is rebuilt. |
Hello, @ecordell . Sorry, was this proposal implemented about olm.relatedImage in the annotation? I see it was marked like future work... |
@ecordell 840a709#diff-4ada87752d32e1f3f585474c722d2633R44 we have short digest, because annotation has limitation in 63 characters and such long image can't be applied: |
See issue operator-framework#1069 for more details
Description of the change:
This is a resurrection of #946
Motivation for the change:
We need to be able to identify related images for mirroring into disconnected environments.