Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: refresh architecture and philosophy docs for clarity purposes #1092

Merged
merged 1 commit into from
Oct 28, 2019
Merged

fix: refresh architecture and philosophy docs for clarity purposes #1092

merged 1 commit into from
Oct 28, 2019

Conversation

exdx
Copy link
Member

@exdx exdx commented Oct 28, 2019

Description of the change:
Small refresh for the architecture and philosophy docs. The main motivation was to be more deliberate about certain wording to lower the confusion a new developer has when approaching the OLM repo for the first time.

Motivation for the change:
General improvements to OLM repository

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 28, 2019
@exdx exdx changed the title fix: refresh architecture and philosophy fix: refresh architecture and philosophy docs for clarity purposes Oct 28, 2019
@exdx
Copy link
Member Author

exdx commented Oct 28, 2019

/test e2e-aws-olm

ecordell
ecordell approved these changes Oct 28, 2019
View reviewed changes
Copy link
Member

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Denton24646, ecordell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2019
@openshift-merge-robot openshift-merge-robot merged commit 8b65924 into operator-framework:master Oct 28, 2019
@exdx exdx deleted the fix/docs-fixup branch October 29, 2019 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecordell ecordell ecordell approved these changes

@njhale njhale Awaiting requested review from njhale

Assignees

@ecordell ecordell

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@exdx @openshift-ci-robot @ecordell @openshift-merge-robot