fix(olm): No longer report status if minKubeVersion not specified #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, OLM will report requirementStatus for `minKubeVersion` even if it is not specified. The status becomes confusing as `minKubeVersion` is not required. After this change, the status is no longer reported if `minKubeVersion` is not specified. Signed-off-by: Vu Dinh <vdinh@redhat.com>
openshift-ci-robot
added
the
size/S
|
/retest |
1 similar comment
|
/retest |
|
/lgtm |
|
/assign @njhale |
jpeeler
suggested changes
Oct 30, 2019
Signed-off-by: Vu Dinh <vdinh@redhat.com>
openshift-ci-robot
added
size/L
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awgreene, dinhxuanvu, jpeeler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, OLM will report requirementStatus for
minKubeVersioneven if it is not specified. The status becomes confusing as
minKubeVersionis not required. After this change, the statusis no longer reported if
minKubeVersionis not specified.Signed-off-by: Vu Dinh vdinh@redhat.com
Description of the change:
No longer report status if minKubeVersion not specified
Motivation for the change:
Currently, OLM will report requirementStatus for
minKubeVersioneven if it is not specified. The status becomes confusing as
minKubeVersionis not required.Reviewer Checklist
/docs