Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1760608: remove resource limits from packageserver #1149

Conversation

exdx
Copy link
Member

@exdx exdx commented Nov 22, 2019

Description of the change:
After merging #1142 there were some concerns about the response time of the packageserver when the console loads all the operators (specifically regarding loading the icons on the page). See
#1142 (comment) for more info. This PR backs out the newly added limits for the packageserver only.
Note: the load time can be improved by making optimizations to the packageserver and potentially the console.

Motivation for the change:
Discussion with the team and the console team regarding the proposed limits for the package server.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@exdx exdx requested review from njhale and kevinrizza November 22, 2019 21:26
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Denton24646
To complete the pull request process, please assign njhale
You can assign the PR to them by writing /assign @njhale in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 22, 2019
@openshift-ci-robot
Copy link
Collaborator

@Denton24646: This pull request references Bugzilla bug 1760608, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1760608: remove resource limits from packageserver

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 22, 2019
@openshift-ci-robot
Copy link
Collaborator

@Denton24646: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-olm c46e7df link /test e2e-aws-olm

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@exdx
Copy link
Member Author

exdx commented Nov 22, 2019

/retry

1 similar comment
@awgreene
Copy link
Member

/retry

@exdx
Copy link
Member Author

exdx commented Nov 25, 2019

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 25, 2019
@exdx
Copy link
Member Author

exdx commented Nov 25, 2019

Holding to see how #1150 performs, may not have to remove the limits after all...

@exdx
Copy link
Member Author

exdx commented Nov 25, 2019

/retry

@exdx exdx closed this Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants