-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make run_console_local.sh working on WSLv1 #1154
fix: make run_console_local.sh working on WSLv1 #1154
Conversation
Hi @wilmardo. Thanks for your PR. I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: wilmardo <info@wilmardenouden.nl>
Signed-off-by: wilmardo <info@wilmardenouden.nl>
/ok-to-test |
/approve I'd like to double check that this still works on other systems as well, since we don't have CI for this script. |
/retest verified that it still works on macos! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell, wilmardo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of the change:
Motivation for the change:
The script wasn't working for me in WSlv1 because
[[ "$(< /proc/version)" == *"@(Microsoft|WSL)"* ]]
never evaluated to true.Simplified the statement by using
uname -r
(no need to grep for Microsoft or WSL) and by usinggrep
The second commit is for making the script sh compatible to support more environments. I couldn't check it on MacOS but according to the internet OSTYPE should be defined.
The for loop is needed since the script is much faster in sh and the if statement to check for running is sometimes run before the container has started.
Reviewer Checklist
/docs